Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make examples files check if matplotlib is available. #928

Merged
merged 4 commits into from
May 29, 2021

Conversation

lawrennd
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #928 (06f6071) into devel (4089a66) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            devel     #928   +/-   ##
=======================================
  Coverage   54.59%   54.60%           
=======================================
  Files         211      211           
  Lines       21564    21564           
  Branches     2891     2891           
=======================================
+ Hits        11772    11774    +2     
  Misses       9240     9240           
+ Partials      552      550    -2     

Copy link
Contributor

@ekalosak ekalosak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: , might be useful to only calculate MPL_AVAILABLE once in e.g. the plotting module so the code isn't repeated, but that's not a blocker.

@lawrennd
Copy link
Member Author

Yes, that would be better.

I'll merge for now and maybe there's a rethink of plotting needed in general ... something for the new discussions channel perhaps?

@lawrennd lawrennd merged commit 111727e into SheffieldML:devel May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants